@pierrejochem Unfortunately (or maybe fortunately?) I haven't had to use this library in awhile, and don't have access to a SharePoint environment to test. However, any implementation seems better than raising NotImplementedError to me.

But I have 😄 Great work from you guys!

@cchurch I could contribute to the Project. If this is possible?

@cchurch I would make the merges and testing

@pierrejochem I ended up writing the exact same code for the add function. When I try to add an attachment using a str object as the content I receive a vague error:
``File "", line unknown
XMLSyntaxError

Hello @bash-j

I need more Details. Could you please try first my version from here:

https://github.com/pierrejochem/python-sharepoint

Hi @pierrejochem

I found the content returned by the request was empty because the server was returning a 400 error, so lxml had nothing to parse. I discovered SharePoint is expecting a base64 array. After a lot of trial and error I found the following code works with a string, a text file and binary files.

def add(self, filename=None, content=None, upload_file=None):
        if upload_file:
            if not filename:
                filename = upload_file
            with open(upload_file, "rb") as filein:
                f = filein.read()
                econtent = base64.b64encode(f).decode()
        else:
            econtent = base64.encodebytes(content.encode()).decode()
        xml = SP.AddAttachment(SP.listName(self.list_id),
                               SP.listItemID(str(self.row_id)),
                               SP.fileName(filename),
                               SP.attachment(econtent))
        response = self.opener.post_soap(LIST_WEBSERVICE,
                                         xml,
                                         soapaction='http://schemas.microsoft.com/sharepoint/soap/AddAttachment')

Sorry, yes of course:

https://msdn.microsoft.com/en-us/library/lists.lists.addattachment(v=office.12).aspx

attachment => A byte array that contains the file to attach by using base-64 encoding.

It was self-evidently for me so I have not ask for it. But you found it by yourself and that is important.